From ddc886e52ec7febe3649f480c14f629e33abba17 Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Thu, 2 Mar 2023 00:08:34 +0800
Subject: [PATCH 1/4] fix: fix slider default height.

---
 src/Semi.Avalonia/Controls/Slider.axaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Semi.Avalonia/Controls/Slider.axaml b/src/Semi.Avalonia/Controls/Slider.axaml
index 0685897..49f0c7b 100644
--- a/src/Semi.Avalonia/Controls/Slider.axaml
+++ b/src/Semi.Avalonia/Controls/Slider.axaml
@@ -88,11 +88,11 @@
                                     <Setter Property="ReservedSpace" Value="{Binding #PART_Track.Thumb.Bounds}" />
                                 </Style>
                             </Grid.Styles>
-                            <Grid x:Name="HorizontalTemplate" MinHeight="50">
+                            <Grid x:Name="HorizontalTemplate">
                                 <Grid.RowDefinitions>
-                                    <RowDefinition Height="15" />
                                     <RowDefinition Height="Auto" />
-                                    <RowDefinition Height="15" />
+                                    <RowDefinition Height="Auto" />
+                                    <RowDefinition Height="Auto" />
                                 </Grid.RowDefinitions>
                                 <TickBar
                                     Name="TopTickBar"

From 37737866ecbec0af1c3c249879b61512d5b63ff2 Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Thu, 2 Mar 2023 00:10:13 +0800
Subject: [PATCH 2/4] fix: fix invalid vertical width binding.

---
 src/Semi.Avalonia/Controls/Slider.axaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Semi.Avalonia/Controls/Slider.axaml b/src/Semi.Avalonia/Controls/Slider.axaml
index 49f0c7b..561a182 100644
--- a/src/Semi.Avalonia/Controls/Slider.axaml
+++ b/src/Semi.Avalonia/Controls/Slider.axaml
@@ -179,9 +179,9 @@
                                 MinWidth="{DynamicResource SliderVerticalWidth}"
                                 RowDefinitions="*,Auto,Auto">
                                 <Grid.ColumnDefinitions>
-                                    <ColumnDefinition Width="{DynamicResource SliderPreContentMargin}" />
                                     <ColumnDefinition Width="Auto" />
-                                    <ColumnDefinition Width="{DynamicResource SliderPostContentMargin}" />
+                                    <ColumnDefinition Width="Auto" />
+                                    <ColumnDefinition Width="Auto" />
                                 </Grid.ColumnDefinitions>
                                 <TickBar
                                     Name="LeftTickBar"

From efa0ff28e7bb5d4bf824061cf853777559a419da Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Thu, 2 Mar 2023 00:11:27 +0800
Subject: [PATCH 3/4] fix: simplify column definitions.

---
 src/Semi.Avalonia/Controls/Slider.axaml | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/src/Semi.Avalonia/Controls/Slider.axaml b/src/Semi.Avalonia/Controls/Slider.axaml
index 561a182..c4eec5a 100644
--- a/src/Semi.Avalonia/Controls/Slider.axaml
+++ b/src/Semi.Avalonia/Controls/Slider.axaml
@@ -88,12 +88,7 @@
                                     <Setter Property="ReservedSpace" Value="{Binding #PART_Track.Thumb.Bounds}" />
                                 </Style>
                             </Grid.Styles>
-                            <Grid x:Name="HorizontalTemplate">
-                                <Grid.RowDefinitions>
-                                    <RowDefinition Height="Auto" />
-                                    <RowDefinition Height="Auto" />
-                                    <RowDefinition Height="Auto" />
-                                </Grid.RowDefinitions>
+                            <Grid x:Name="HorizontalTemplate" RowDefinitions="Auto,Auto,Auto">
                                 <TickBar
                                     Name="TopTickBar"
                                     Grid.Row="0"
@@ -177,12 +172,8 @@
                             <Grid
                                 x:Name="VerticalTemplate"
                                 MinWidth="{DynamicResource SliderVerticalWidth}"
+                                ColumnDefinitions="Auto,Auto,Auto"
                                 RowDefinitions="*,Auto,Auto">
-                                <Grid.ColumnDefinitions>
-                                    <ColumnDefinition Width="Auto" />
-                                    <ColumnDefinition Width="Auto" />
-                                    <ColumnDefinition Width="Auto" />
-                                </Grid.ColumnDefinitions>
                                 <TickBar
                                     Name="LeftTickBar"
                                     Grid.RowSpan="3"

From 1b50bc54373b7e937f7bc66ac45dd75c155127ff Mon Sep 17 00:00:00 2001
From: Zhang Dian <54255897+zdpcdt@users.noreply.github.com>
Date: Thu, 2 Mar 2023 10:52:41 +0800
Subject: [PATCH 4/4] fix: delete RowDefinitions.

---
 .../Semi.Avalonia.Demo/Pages/SliderDemo.axaml | 25 +++++++++++++++++++
 src/Semi.Avalonia/Controls/Slider.axaml       |  8 ++----
 2 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/demo/Semi.Avalonia.Demo/Pages/SliderDemo.axaml b/demo/Semi.Avalonia.Demo/Pages/SliderDemo.axaml
index c526b1e..f25675a 100644
--- a/demo/Semi.Avalonia.Demo/Pages/SliderDemo.axaml
+++ b/demo/Semi.Avalonia.Demo/Pages/SliderDemo.axaml
@@ -62,6 +62,15 @@
                 TickFrequency="10"
                 TickPlacement="TopLeft"
                 Value="0" />
+            <Slider
+                Height="300"
+                IsSnapToTickEnabled="True"
+                Maximum="100"
+                Minimum="0"
+                Orientation="Vertical"
+                TickFrequency="10"
+                TickPlacement="Outside"
+                Value="0" />
             <Slider
                 Height="300"
                 Classes="ToolTip"
@@ -71,6 +80,22 @@
                 TickFrequency="10"
                 TickPlacement="TopLeft"
                 Value="0" />
+            <Slider
+                Height="300"
+                IsDirectionReversed="True"
+                Maximum="100"
+                Minimum="0"
+                Orientation="Vertical"
+                TickFrequency="10"
+                Value="0" />
+            <Slider
+                Height="300"
+                IsEnabled="False"
+                Maximum="100"
+                Minimum="0"
+                Orientation="Vertical"
+                TickFrequency="10"
+                Value="30" />
         </StackPanel>
     </StackPanel>
 </UserControl>
diff --git a/src/Semi.Avalonia/Controls/Slider.axaml b/src/Semi.Avalonia/Controls/Slider.axaml
index c4eec5a..949823b 100644
--- a/src/Semi.Avalonia/Controls/Slider.axaml
+++ b/src/Semi.Avalonia/Controls/Slider.axaml
@@ -172,11 +172,10 @@
                             <Grid
                                 x:Name="VerticalTemplate"
                                 MinWidth="{DynamicResource SliderVerticalWidth}"
-                                ColumnDefinitions="Auto,Auto,Auto"
-                                RowDefinitions="*,Auto,Auto">
+                                ColumnDefinitions="Auto,Auto,Auto">
                                 <TickBar
                                     Name="LeftTickBar"
-                                    Grid.RowSpan="3"
+                                    Grid.Column="0"
                                     Width="{DynamicResource SliderTickVerticalWidth}"
                                     Margin="0,0,4,0"
                                     HorizontalAlignment="Right"
@@ -190,7 +189,6 @@
                                     Ticks="{TemplateBinding Ticks}" />
                                 <TickBar
                                     Name="RightTickBar"
-                                    Grid.RowSpan="3"
                                     Grid.Column="2"
                                     Width="{DynamicResource SliderTickVerticalWidth}"
                                     Margin="4,0,0,0"
@@ -205,9 +203,7 @@
                                     Ticks="{TemplateBinding Ticks}" />
                                 <Track
                                     Name="PART_Track"
-                                    Grid.RowSpan="3"
                                     Grid.Column="1"
-                                    Grid.ColumnSpan="1"
                                     IsDirectionReversed="{TemplateBinding IsDirectionReversed}"
                                     Maximum="{TemplateBinding Maximum}"
                                     Minimum="{TemplateBinding Minimum}"